Skip to content

Commit

Permalink
Rename ClientSignatureContainer to Pkcs7GenerateSignatureContainer
Browse files Browse the repository at this point in the history
  • Loading branch information
nguyennv committed Jul 12, 2016
1 parent 441f3b8 commit db8e92a
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion server/src/main/java/org/opencps/pki/PdfSigner.java
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ public Boolean sign(byte[] signature) throws SignatureException {
*/
@Override
public Boolean sign(byte[] signature, String filePath) throws SignatureException {
ExternalSignatureContainer container = new ClientSignatureContainer(this, signature);
ExternalSignatureContainer container = new Pkcs7GenerateSignatureContainer(this, signature);
return signExternal(container, filePath);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
*
* @author Nguyen Van Nguyen <[email protected]>
*/
public class ClientSignatureContainer implements ExternalSignatureContainer {
public class Pkcs7GenerateSignatureContainer implements ExternalSignatureContainer {

private byte[] signature;

Expand All @@ -50,7 +50,7 @@ public class ClientSignatureContainer implements ExternalSignatureContainer {
/**
* Constructor
*/
public ClientSignatureContainer(PdfSigner signer, byte[] signature) {
public Pkcs7GenerateSignatureContainer(PdfSigner signer, byte[] signature) {
this.signer = signer;
this.signature = signature;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,20 +54,20 @@
/**
* @author Nguyen Van Nguyen <[email protected]>
*/
public class ClientSignatureContainerTest extends TestCase {
public class Pkcs7GenerateSignatureContainerTest extends TestCase {
private static final String certPath = "./src/test/java/resources/cert.pem";
private static final String keyPath = "./src/test/java/resources/key.pem";
private static final String pdfPath = "./src/test/java/resources/opencps.pdf";

public ClientSignatureContainerTest(String testName) {
public Pkcs7GenerateSignatureContainerTest(String testName) {
super(testName);
}

/**
* @return the suite of tests being tested
*/
public static Test suite() {
return new TestSuite(ClientSignatureContainerTest.class);
return new TestSuite(Pkcs7GenerateSignatureContainerTest.class);
}

public void testSignatureContainer() throws GeneralSecurityException, IOException {
Expand All @@ -94,7 +94,7 @@ public void testSignatureContainer() throws GeneralSecurityException, IOExceptio
@SuppressWarnings("resource")
InputStream rg = new RASInputStream(new RandomAccessSourceFactory().createRanged(readerSource, gaps));

ExternalSignatureContainer container = new ClientSignatureContainer(signer, extSignature);
ExternalSignatureContainer container = new Pkcs7GenerateSignatureContainer(signer, extSignature);
assertTrue(container.sign(rg).length > 0);
}

Expand All @@ -111,7 +111,7 @@ public void testSignatureContainerWithInvalidSignature() throws IOException, Sig
pemReader.close();
PrivateKeySignature signature = new PrivateKeySignature(privateKey, signer.getHashAlgorithm().toString(), "BC");
byte[] extSignature = signature.sign(signer.computeHash());
ExternalSignatureContainer container = new ClientSignatureContainer(signer, extSignature);
ExternalSignatureContainer container = new Pkcs7GenerateSignatureContainer(signer, extSignature);
try {
container.sign(mock(InputStream.class));
fail("Missing exception");
Expand All @@ -125,7 +125,7 @@ public void testSignatureContainerWithEmptySignature() throws CertificateExcepti
CertificateFactory cf = CertificateFactory.getInstance("X.509");
X509Certificate cert = (X509Certificate) cf.generateCertificate(new FileInputStream(new File(certPath)));
PdfSigner signer = new PdfSigner(pdfPath, cert);
ExternalSignatureContainer container = new ClientSignatureContainer(signer, new byte[0]);
ExternalSignatureContainer container = new Pkcs7GenerateSignatureContainer(signer, new byte[0]);
try {
container.sign(mock(InputStream.class));
fail("Missing exception");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public Pksc7SignatureContainerTest(String testName) {
* @return the suite of tests being tested
*/
public static Test suite() {
return new TestSuite(ClientSignatureContainerTest.class);
return new TestSuite(Pkcs7GenerateSignatureContainerTest.class);
}

public void testSignatureContainer() throws FileNotFoundException, GeneralSecurityException {
Expand Down

0 comments on commit db8e92a

Please sign in to comment.