Feature gallery #31
Feature gallery #31
Conversation
Added funnel svg Added topbar images: menu and search svg Added unchecked image for the video-card component
Added a new flex placeholder for wrapping images up to the container Added support for border-radius in mozilla (wasn't working correctly) Changed some background colors variables comming from design department and included new variables with sizes & border radius styling Included scrolling to the body for infinite scroll on y axis & removed text-decoration from <a> link tags
modified brand vimojo svg logo to fit the right fill color
…re-gallery # Conflicts: # languages/en_us.js # languages/es_es.js # sass/base/_variables.scss
make topbar fixed to the body container so only the content scrolls up/down added infinite scroll to non featured videos clean gallery service & controller prevent from visual issues on video-card
|
After trying lots of things, I found that horizontal infinite scrolling is not supported by this library yet. It seems someone did that feature but the branch is not merged to the master branch since it has no test |
sass/base/_variables.scss
Outdated
| $grey: #5A6978; | ||
| $lightGrey: #B6B6B6; | ||
|
|
||
| //gradient colors |
There was a problem hiding this comment.
From here to line 24, what are this things doing here? We're not using any blue gradient, as far as I know. Also, we already have background colors (both in normal and light version) some lines down (30 and 31).
Also are maintag and mainQuestion variable names accurate? Aren't just other way to use textDark?
There was a problem hiding this comment.
I've just fixed your requested changes =)
| VIDEO_CARD_VERIFIED: 'Verified', | ||
| VIDEO_CARD_NOT_VERIFIED: 'Not verified', | ||
| DOWNLOAD_CODE: 'Enter your download code', | ||
| VERIFIED: 'Verified video', |
There was a problem hiding this comment.
What happens with video-download view (line 26) when you remove this line?
There was a problem hiding this comment.
As I've seen, that deleted line is correct, but what is not correct and you're right is the calling to the correct variable in the view. At this point, we've changed VERIFIED to VIDEO_CARD_VERIFIED, so I'm updating the view with this name.
There was a problem hiding this comment.
So, if there's not only being calling in video-card component... Shall the name be VIDEO_CARD_VERIFIED or better something just like VIDEO_VERIFIED?
| VIDEO_CARD_VERIFIED: 'Verificado', | ||
| VIDEO_CARD_NOT_VERIFIED: 'No verificado', | ||
| DOWNLOAD_CODE: 'Introduce un código de descarga', | ||
| VERIFIED: 'Video verificado', |
Remove $stateParams since it's not used Added test
add gallery controller test
…d into feature-gallery
fix a bug in video-download for a missing constant
…d into feature-gallery
…-frontend into feature-gallery
| @@ -1,8 +1,9 @@ | |||
| video-card { | |||
| div { | |||
| div.card-container { | |||
There was a problem hiding this comment.
so... if you have defined a class... for what do you specify the div tag?
Remove fallback-url since It doesn't exist
|
<3 nice job guys! DO NOT close this PR until it's accepted |
… that has been upload by gustavos.
…that has been upload by gustavos.
| @@ -1,2 +1,2 @@ | |||
| v0.0.4 | |||
| - Adding user feedback about code validity on downloading original video | |||
| v0.1.0 | |||
There was a problem hiding this comment.
package.json version is inconsistent with 0.1.0
"version": "0.0.4",
javierLiarte
left a comment
javierLiarte
left a comment
There was a problem hiding this comment.
Great work, guys, let's move forward! 👍
| { | ||
| "name": "vimojo-platform-frontend", | ||
| "version": "0.0.4", | ||
| "version": "0.1.0", |
No description provided.