Skip to content

Conversation

@AndrewChubatiuk
Copy link
Contributor

@AndrewChubatiuk AndrewChubatiuk commented Oct 24, 2025

  • update prev spec in CR annotations after successful or failed reconcile. currently annotation is updated before reconcile, which may lead to dangling resources if one of reconcile loops finished with an error, that doesn't lead to CR failed state. this may explain e2e flaky tests in CI
  • e2e: print resources that were not removed
  • e2e: do not enclose CR update into Eventually since update should be applied immediately and repetitive calls may lead to conflicts
  • e2e: consistently use nsn instead of nss for type.NamespacedName variables
  • added predicate filter to exclude change in last-applied-spec annotation from reconcile

@AndrewChubatiuk AndrewChubatiuk force-pushed the print-not-removed-resource branch from 3215c31 to a020d1e Compare October 25, 2025 04:48
@AndrewChubatiuk AndrewChubatiuk changed the title print not removed resource update prev spec annotation after successful reconcile Oct 25, 2025
@AndrewChubatiuk AndrewChubatiuk force-pushed the print-not-removed-resource branch 2 times, most recently from 0bf238e to 69accf4 Compare October 25, 2025 10:03
@AndrewChubatiuk AndrewChubatiuk force-pushed the print-not-removed-resource branch from 69accf4 to 345de1a Compare October 25, 2025 10:04
@AndrewChubatiuk AndrewChubatiuk changed the title update prev spec annotation after successful reconcile do not update prev spec annotation in case of CR expanding state Oct 25, 2025
@AndrewChubatiuk AndrewChubatiuk force-pushed the print-not-removed-resource branch 18 times, most recently from c2b6c4d to ba67d83 Compare October 26, 2025 17:57
@AndrewChubatiuk AndrewChubatiuk force-pushed the print-not-removed-resource branch from ba67d83 to d26bf1b Compare October 26, 2025 18:18
@f41gh7
Copy link
Collaborator

f41gh7 commented Oct 26, 2025

This was already implemented, but replaced with current version, please see commit and issues history

@AndrewChubatiuk
Copy link
Contributor Author

AndrewChubatiuk commented Oct 26, 2025

before this commit prev spec annotation was updated after successful reconcile which led to infinite loops for CRs that are always failing and after this commit prev spec annotation is updated before reconcile but it disabled dangling resources cleanup if CR update was not able to complete within a single reconcile execution (create deployment and timed out during first reconcile, which ended with expanding state and second reconcile, which switched state to operational)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants