Skip to content

(vl|vt|vm)cluster: take into account prev insert/select section presence while making a decision on lb resources removal #1564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

(vl|vt|vm)cluster: take into account prev insert/select section presence while making a decision on lb resources removal #1564

wants to merge 3 commits into from
+241 −213

Conversation

@AndrewChubatiuk
Copy link
Contributor

@AndrewChubatiuk AndrewChubatiuk commented Oct 22, 2025 •
edited
Loading

  • take into account presence of prev select and insert sections on lb specific resource removal
  • updated variable names to ones with more clear meaning
  • move pods specific reconcile functions to a separate file, before part of pods specific functions was in deploy.go and another one was in statefulset.go

@AndrewChubatiuk AndrewChubatiuk force-pushed the delete-lb-service-if-app-is-disabled branch 16 times, most recently from 72fcb1f to ed847e1 Compare October 23, 2025 09:00
@AndrewChubatiuk AndrewChubatiuk force-pushed the delete-lb-service-if-app-is-disabled branch 4 times, most recently from 173dcb7 to 4c1ad1c Compare October 24, 2025 18:36
@AndrewChubatiuk AndrewChubatiuk force-pushed the delete-lb-service-if-app-is-disabled branch from 4c1ad1c to 1a78543 Compare October 24, 2025 18:40
@AndrewChubatiuk AndrewChubatiuk changed the title (vl|vt|vm)cluster: remove respective lb service, while disabling select/insert (vl|vt|vm)cluster: take into account insert/select section presence while making a decision on lb resources removal Oct 26, 2025
@AndrewChubatiuk AndrewChubatiuk changed the title (vl|vt|vm)cluster: take into account insert/select section presence while making a decision on lb resources removal (vl|vt|vm)cluster: take into account prev insert/select section presence while making a decision on lb resources removal Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@f41gh7 f41gh7 Awaiting requested review from f41gh7 f41gh7 is a code owner

@Haleygo Haleygo Awaiting requested review from Haleygo Haleygo is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AndrewChubatiuk