utils.go: fix index out of range panic when too small number of arg…

…s is passed to rollup function inside the query at IsLikelyInvalid()
VictoriaMetrics · Dec 5, 2024 · 788d984 · 788d984
1 parent e168a92
commit 788d984
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/utils.go b/utils.go
@@ -84,7 +84,7 @@ func IsLikelyInvalid(e Expr) bool {
 			return
 		}
 		idx := GetRollupArgIdx(fe)
-		if idx < 0 {
+		if idx < 0 || idx >= len(fe.Args) {
 			return
 		}
 		arg := fe.Args[idx]

diff --git a/utils_test.go b/utils_test.go
@@ -117,6 +117,9 @@ func TestIsLikelyInvalid(t *testing.T) {
 	f(`rate(rate(foo))`, true)
 	f(`1 + rate(label_set(foo, "bar", "baz"))`, true)
 	f(`rate(sum(foo) offset 5m)`, true)
+
+	// invalid number of args
+	f(`quantile_over_time(foo)`, false)
 }
 
 func TestIsSupportedFunction(t *testing.T) {