feature: [vt] reject out of retention request #49
+110
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JayiceZ <[email protected]>
Signed-off-by: JayiceZ <[email protected]>
…vtselect-retention-period # Conflicts: # app/vtselect/traces/query/query.go
…vtselect-retention-period Signed-off-by: JayiceZ <[email protected]> # Conflicts: # app/vtselect/traces/query/query.go
…vtselect-retention-period
…period Signed-off-by: JayiceZ <[email protected]> # Conflicts: # app/vtselect/traces/query/query.go # app/vtstorage/main.go # app/vtstorage/netselect/netselect.go
|
There are some implementations I'm unsure of, may be need further discussion. I'm checking vtstorage's rejection by matching string in the error response, as I can't just rely on a specific HTTP status code. However, I'm not entirely sure about this implementation. |
… by using status code. updated ingestion logic as well
jiekun
force-pushed
the
vtselect-retention-period
branch
from
faaf03b to
481caa6
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #49 +/- ##
========================================
Coverage ? 5.00%
========================================
Files ? 31
Lines ? 5552
Branches ? 0
========================================
Hits ? 278
Misses ? 5267
Partials ? 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Reject request that query time range exceeds
retentionPeriod, and avoiding RPC burst problem caused by querying non-exist TraceID describe in #48Checklist
The following checks are mandatory: