Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #4 Ready For Review #16

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Issue #4 Ready For Review #16

wants to merge 9 commits into from

Conversation

robecampbelljr
Copy link
Collaborator

@robecampbelljr robecampbelljr commented May 2, 2023

Issue #4

Issue #4 Deployment

Inside './issue-4/index.html' ...

  • Three sections changing order depending on the media query
  • Image has a width of 80% on desktop and 100% on tablet and mobile
  • Three buttons all have border, shadow, and change color on hover
  • All sections are animated using keyframes on page load

@netlify
Copy link

netlify bot commented May 2, 2023

Deploy Preview for papaya-snickerdoodle-fdaf9f ready!

Name Link
🔨 Latest commit a7ef1b4
🔍 Latest deploy log https://app.netlify.com/sites/papaya-snickerdoodle-fdaf9f/deploys/646bd94b075cb20008e82660
😎 Deploy Preview https://deploy-preview-16--papaya-snickerdoodle-fdaf9f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sotheencourager
Copy link
Contributor

Hi @robecampbelljr

This is looking good. However, the tablet condition does not seemed to be met. When I resized my screen and use an actual tablet, it is looking like the web. Slight tweak and you will be there.

@robecampbelljr robecampbelljr requested a review from a team May 18, 2023 19:59
Copy link
Member

@axecopfire axecopfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solves the prompts directly. However, I don't see your portfolio reflected here at all. The point is to incorporate the standards into your portfolio. Please update so it looks like what you designed in week 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants