Minimization #476
Open
Minimization #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurajsic
reviewed
Dec 2, 2024
jurajsic
reviewed
Dec 3, 2024
Adda0
reviewed
Dec 4, 2024
| if (str_algo == "hopcroft") { | ||
| /* default */; | ||
| } else if (str_algo == "brzozowski") { | ||
| algo = algorithms::minimize_brzozowski; |
There was a problem hiding this comment.
Maybe this should be named make_minimal_dfa_brzozowski()? To show it can be used for NFAs.
There was a problem hiding this comment.
But this will break the naming convention for minimizazion algorithms.
There was a problem hiding this comment.
True, but Brzozowski does not perform minimization as per the definition given by Lukáš. But this is debatable. What does @jurajsic think?
There was a problem hiding this comment.
I do not know, but I realized that this change, that minimize now HAVE to take DFA, might break noodler (and anyone using mata, if such people exists), because before it was assumed it takes nfa and calls brzozowski.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: