Skip to content

[VPD-74] Etherscan V2 Integration #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 20, 2025
Merged

[VPD-74] Etherscan V2 Integration #291

merged 6 commits into from
Oct 20, 2025

Conversation

@web3rover
Copy link
Contributor

@web3rover web3rover commented Aug 20, 2025

Description

Resolves #

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@web3rover web3rover requested a review from chechu August 20, 2025 10:05
@web3rover web3rover self-assigned this Aug 20, 2025
@fred-venus
Copy link
Contributor

fred-venus commented Oct 11, 2025

I encountered the api version incompatible issue while trying to verify the contract, agree we should merge this. Saw it's opened 2 months ago, any reason we still not merge it yet ?

fred-venus
fred-venus reviewed Oct 11, 2025
View reviewed changes
fred-venus
fred-venus reviewed Oct 11, 2025
View reviewed changes
@fred-venus
Copy link
Contributor

fred-venus commented Oct 11, 2025 •
edited
Loading

And pls update README as well since it will no longer be npx hardhat etherscan-verify --network <network-name>

@toolsvenus toolsvenus mentioned this pull request Oct 13, 2025
Closed
4 tasks
@web3rover web3rover requested a review from fred-venus October 17, 2025 06:30
@github-actions
Copy link

github-actions bot commented Oct 17, 2025

Code Coverage

Package Line Rate Branch Rate Health
contracts 98% 91% ✔
contracts.interfaces 100% 100% ✔
contracts.lib 100% 100% ✔
contracts.oracles 89% 80% ✔
contracts.oracles.common 98% 93% ✔
Summary 93% (355 / 381) 86% (166 / 194) ✔

@web3rover web3rover merged commit 218740e into develop Oct 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fred-venus fred-venus fred-venus approved these changes

@chechu chechu Awaiting requested review from chechu

Assignees

@web3rover web3rover

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@web3rover @fred-venus