Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add LibString methods for packing + unpacking + directReturn #107

Merged
merged 8 commits into from
Sep 25, 2022

Conversation

Vectorized
Copy link
Owner

@Vectorized Vectorized commented Sep 25, 2022

Description

For #105.

Inspired by transmissions11/solmate#320.

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge snapshot?
  • Ran npm run lint?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

Philogy and others added 2 commits September 25, 2022 14:27
* Implement and test LibString.packOne

* Improve comment and implement unpackeOne

* Make unpackOne branchless

* Remove "safe" from pack one test names

* Add and test packTwo, unpackTwo

* Improve comments

* Add and test directReturn

* Update gas snapshot

* Update comments

* Test packTwo overflow protection

* Optimize unpacks

* Ensure comments comply with contribution guidelines

* Update comment
@Vectorized Vectorized changed the title ✨ Add LibString methods pack/unpack one/two and directReturn (#106) ✨ Add LibString methods for packing + unpacking + directReturn Sep 25, 2022
@Vectorized Vectorized linked an issue Sep 25, 2022 that may be closed by this pull request
@Vectorized Vectorized merged commit fd8e501 into main Sep 25, 2022
@Vectorized Vectorized deleted the ls2_2 branch September 27, 2022 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ New LibString functions (round 2)
2 participants