Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new CIBC logos #84

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add new CIBC logos #84

wants to merge 4 commits into from

Conversation

Armiiin
Copy link

@Armiiin Armiiin commented Jun 24, 2024

Adding the updated official CIBC logos.

@Armiiin
Copy link
Author

Armiiin commented Jun 24, 2024

Some comments post-pull request :

The imagecheck seems to be failing on existing files on repo?

The namecheck: Can't find the naming convention for alternative official logos. Feel free to change or remove it.

The metacheck: Couldn't really see what went wrong there, other index metadata files seemed fine having the same structure. (e.g. https://github.com/VectorLogoZone/vectorlogozone/blob/main/www/logos/google/index.md )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant