Feat/multimodal knowledge store#489
Draft
Izukimat wants to merge 2 commits intoVectorInstitute:mainfrom
Draft
Conversation
added 2 commits
July 13, 2025 08:49
nerdai
reviewed
Jul 14, 2025
Collaborator
nerdai
left a comment
There was a problem hiding this comment.
Will take another look in a bit!
|
|
||
|
|
||
| # Union type for backward compatibility | ||
| QueryEmbedding = Union[list[float], MultiModalEmbedding] |
Collaborator
There was a problem hiding this comment.
Ohh, I kind of like how you did this better. Subtle difference, but I think cleaner than what I got.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What does this PR do? Please provide a brief summary of the changes introduced.
Expand BaseKnowledgeStore and RAGSystem to support multimodal retrieval with separate collections strategy
Description
This PR expands the knowledge store layer to support multimodal embeddings and implements the separate collections strategy for multimodal RAG. Key changes include:
BaseKnowledgeStore Changes:
MultiModalEmbeddingtype supporting text, image, audio, and video embeddingsretrieve()method signature to acceptQueryEmbedding(Union oflist[float]orMultiModalEmbedding)retrieve_by_modality()method for modality-specific collection queriesRAG System Changes:
str | Queryfor multimodal input support_prepare_modality_embeddings()method to extract embeddings by modality from retriever tensorsretrieve()method to query separate collections for each modality and merge results_format_context()with configuration-driven approach for modality-specific formattingAny information reviewers should be aware of:
Checklist
Before submitting your PR, please check off the following:
make lint)