Conversation
Viky397
reviewed
May 8, 2025
Viky397
reviewed
May 8, 2025
Viky397
reviewed
May 8, 2025
Viky397
reviewed
May 8, 2025
Viky397
reviewed
May 8, 2025
Viky397
reviewed
May 8, 2025
Viky397
reviewed
May 8, 2025
Viky397
reviewed
May 8, 2025
nerdai
reviewed
May 9, 2025
Collaborator
nerdai
left a comment
There was a problem hiding this comment.
Overall, these were all an awesome read IMO. I only found a couple of very minor grammatical/math-text issues.
In addition to those, I think the only other items were:
- Can we have .svg versions of all images (this may handle the dark vs. light themese) automatically for us, depending on how you created these images.
- For the algorithms, and totally up to you (I'm good either way), we could also use markdown blocks as indicated in one of my review comments (and used in the KV Cache pocket ref).
- I think we should change the Summary.md to make the pocket refs that are not available yet to be greyed out.
Other than that, I think these are good to land, and am excited for this FL book to be shared more broadly to our community!
nerdai
reviewed
May 9, 2025
Viky397
approved these changes
May 9, 2025
Viky397
left a comment
There was a problem hiding this comment.
Left a few typo comments. Looks great, thanks for getting these all done David!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[FL] Federated Learning
[FL] Add Basic FL Pocket Ref, Add FedSGD Pocket Ref, Add FedAvg Pocket Ref
Type of Change
Book
Description
Refactored the FL book a bit to make it flow a little more cleanly. Fleshed out the core and horizontal FL chapters. Specifically:
Checklist
{{#author}}or{{#authors}})mdbook watch books/<book-name> --open