Remove ARC-related Obj-C Code from decompilation #52
Conversation
|
Before I do a review, I do believe that this should be placed behind a setting so that it can be enabled/disabled as desired. |
jonpalmisc
left a comment
jonpalmisc
left a comment
There was a problem hiding this comment.
Cursory glance did not reveal any catastrophic mistakes, just minor fixes needed. Not on a computer where I can test this functionally at the moment, however.
Question: What happens when the setting is toggled after initial analysis? My intuition would tell me that functions that end up getting re-analyzed would have the ARC code removed, but old ones wouldn't? Not sure what the "correct" behavior here should be though.
|
This is functional but appears to be partially broken on newer arm64 format binaries which stub code out heavily. Merge blocked pending addressing Vector35/binaryninja-api#5563 |
No description provided.