[CMake] Allow flexible user plugin install location #7547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a cache variable of the same name as the previous normal variable that users can set to a specific path for user plugin installation destination. This is primarily to help with CI builds to make it easier to find where the final plugin is located before uploading as a release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a cache variable of the same name as the previous normal variable that users can set to a specific path for user plugin installation destination.
This is primarily to help with CI builds to make it easier to find where the final plugin is located before uploading as a release.
NOTE: I wasn't sure the best way to handle the duplicate variables, so I just modified both locations in the same way. The effect of setting the
BN_USER_PLUGINS_DIRcache variable multiple times shouldn't be an issue, but I'm happy to change it to something better if you have some suggestions. In fact, withBN_USER_PLUGINS_DIRas a cache variable, we could remove the duplication in thebn_install_pluginfunction.