Add method to get CoreFlag from Flag operation #7423
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-a-johnson
had a problem deploying
to
testing
GitHub Actions
Failure
|
|
james-a-johnson
had a problem deploying
to
testing
GitHub Actions
Failure
james-a-johnson
had a problem deploying
to
testing
GitHub Actions
Failure
james-a-johnson
had a problem deploying
to
testing
GitHub Actions
Failure
james-a-johnson
had a problem deploying
to
testing
GitHub Actions
Failure
|
Thank you for the PR, I made some changes on https://github.com/Vector35/binaryninja-api/tree/get-flag-rust-api if you would like to review them and let me know if they seem reasonable. |
Those changes look fine to me. Thanks for including those! |
|
Merged with 20eba12 thank you for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Flag LLIL operation does not have a method for getting the ID of the flag that is being read in the rust API. This adds a method to do that and updates the debug formatting of the operation to include the source flag.