Supports pointer base types and offsets in Rust API #7351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
LGTM, not sure why the rust CI stuff did not run (unrelated). Seeing as we still have a single monolithic type builder in the rust api this is fine. In the future we will be trying to split it up into each "kind" of type so that people don't try and set these for an integer, again, unrelated to this PR just trying to add context where I can. |
emesare
force-pushed
the
pointer-base-type
branch
from
2a4a4d2 to
9124b7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements Rust API functions to set and read the pointer base type and its accompanying offset in TypeBuilder and to read the respective properties from a Type.