Skip to content

Fix MachO loading some settings too early #7118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix MachO loading some settings too early #7118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions view/macho/machoview.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,10 +203,6 @@ MachoView::MachoView(const string& typeName, BinaryView* data, bool parseOnly):
Ref<BinaryViewType> universalViewType = BinaryViewType::GetByName("Universal");
bool isUniversal = (universalViewType && universalViewType->IsTypeValidForData(data));

Ref<Settings> viewSettings = Settings::Instance();
m_extractMangledTypes = viewSettings->Get<bool>("analysis.extractTypesFromMangledNames", data);
m_simplifyTemplates = viewSettings->Get<bool>("analysis.types.templateSimplifier", data);

Ref<Settings> settings = data->GetLoadSettings(typeName);
if (settings && settings->Contains("loader.macho.universalImageOffset"))
{
Expand Down Expand Up @@ -1096,6 +1092,10 @@ bool MachoView::Init()

SetOriginalImageBase(initialImageBase);
uint64_t preferredImageBase = initialImageBase;
Ref<Settings> viewSettings = Settings::Instance();
m_extractMangledTypes = viewSettings->Get<bool>("analysis.extractTypesFromMangledNames", this);
m_simplifyTemplates = viewSettings->Get<bool>("analysis.types.templateSimplifier", this);

bool platformSetByUser = false;
if (settings)
{
Expand Down