Skip to content

[SharedCache] Add a section for an image header #6514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

WeiN76LQh
Copy link

Similar to what is discussed in PR #6513 its useful to be able to see where an image header is as sometimes you want to inspect the load commands. Without a section its not very obvious where the header is.

The naming scheme of ${imageName}::__header was chosen based on the naming choice of the DSC header.

Similar to what is discussed in PR Vector35#6513 its useful to be able to see where an image header is as sometimes you want to inspect the load commands. Without a section its not very obvious where the header is.

The naming scheme of `${imageName}::__header` was chosen based on the naming choice of the DSC header.
@emesare emesare self-assigned this Mar 30, 2025
@emesare
Copy link
Member

emesare commented Mar 30, 2025

The requested feature is on https://github.com/Vector35/binaryninja-api/tree/test_shared_cache_stuff_prime_0

I took a different approach:

m_view->AddUserSection(headerSection, header.textBase, headerSectionSize, ReadOnlyDataSectionSemantics);

If that resolves your request than we can close this when that branch is merged

@emesare emesare added the File Format: SharedCache Issue with the dyld_shared_cache plugin label Mar 30, 2025
@emesare emesare added this to the Gallifrey milestone Mar 30, 2025
@WeiN76LQh
Copy link
Author

I haven't tested it but that looks like a smarter strategy

@fuzyll
Copy link
Contributor

fuzyll commented Apr 3, 2025

That branch has been merged to dev now. If you're able to test it out and let us know if that works for you, that'd be great. If it does, we'll close this PR. If it doesn't, we'd like to know what's still problematic so we can work with you to get it fixed.

Thanks!

@fuzyll fuzyll added the State: Blocked (Customer) Issue is blocked on waiting for a response from a customer label Apr 3, 2025
@emesare emesare closed this Apr 3, 2025
@fuzyll fuzyll removed the State: Blocked (Customer) Issue is blocked on waiting for a response from a customer label Apr 3, 2025
@fuzyll
Copy link
Contributor

fuzyll commented Apr 3, 2025

Should be addressed in builds >= 5.0.7148-dev.

@WeiN76LQh
Copy link
Author

That branch has been merged to dev now. If you're able to test it out and let us know if that works for you, that'd be great. If it does, we'll close this PR. If it doesn't, we'd like to know what's still problematic so we can work with you to get it fixed.

Thanks!

Seems all good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
File Format: SharedCache Issue with the dyld_shared_cache plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants