Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade firmware module #522

Merged
merged 6 commits into from
Aug 26, 2024
Merged

Upgrade firmware module #522

merged 6 commits into from
Aug 26, 2024

Conversation

Vaskivskyi
Copy link
Owner

@Vaskivskyi Vaskivskyi commented Aug 25, 2024

@Vaskivskyi Vaskivskyi added enhancement New feature or request breaking Breaking changes labels Aug 25, 2024
Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 99.51691% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.38%. Comparing base (4eba40c) to head (bf78183).
Report is 1 commits behind head on dev.

Files Patch % Lines
asusrouter/modules/identity.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #522      +/-   ##
==========================================
+ Coverage   69.16%   70.38%   +1.22%     
==========================================
  Files          63       63              
  Lines        3703     3836     +133     
==========================================
+ Hits         2561     2700     +139     
+ Misses       1142     1136       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Vaskivskyi
Copy link
Owner Author

This fixes already

  • the original 826 and the comment
  • the original 813 and the comment

@Vaskivskyi Vaskivskyi merged commit b41a3e1 into dev Aug 26, 2024
12 checks passed
@Vaskivskyi Vaskivskyi deleted the fw branch August 26, 2024 17:59
Vaskivskyi added a commit that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes enhancement New feature or request
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

1 participant