Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NamalskEvents and use GetNamEventManager API #163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

S-S-X
Copy link

@S-S-X S-S-X commented Sep 28, 2023

Does not work so make it work, this seems to work.

@S-S-X
Copy link
Author

S-S-X commented Sep 28, 2023

@Da0ne or @GravityWolfNotAmused you still working on this project?

Does this seem acceptable change to make Namalsk events work again? Kind of works for me... thing is I have not actually tested changes to actual VPP-Admin-Tools mod but through adding another ChatCommand to manager from outside.

So it should be exact same but I do not really have any DayZ modding experience so...

Also issue why it does not work might actually be elsewhere, no idea but only one thing comes to mind:


If this check does not work then this PR also wouldn't fix anything and would just make it use that event manager wrapper.

@GravityWolfNotAmused
Copy link
Contributor

I'm doubtful this will succeed in testing with other maps; however, I'm looking at this from a phone in the car.

If you took your changes and used it without namalsk, I'm pretty sure this will fail to compile.

@S-S-X
Copy link
Author

S-S-X commented Sep 29, 2023

Well yeah, I guess I've fixed issue. This time actually verified at least some things instead of just throwing in code that worked elsewhere.

And also like I thought problem wasn't actually event there but with VPPAT_IsModLoadded checks, there's actually underscore in name.
Anyway left changes to use API for NamEventManager access instead of direct fields.

But still have not actually tested changes to this mod, but I think it should work now.

@S-S-X S-S-X changed the title Fix NamalskEvents and use NamEventManager Fix NamalskEvents and use GetNamEventManager API Oct 1, 2023
@S-S-X
Copy link
Author

S-S-X commented Oct 1, 2023

@GravityWolfNotAmused cleaned up a bit and tested, seems to work fine now. Does it look good now?

@GravityWolfNotAmused
Copy link
Contributor

Have you tested with and without namalsk?

@S-S-X
Copy link
Author

S-S-X commented Oct 1, 2023

Have you tested with and without namalsk?

Tested with and without Namalsk Survival, both tests on Namalsk map. Without survival mod (which brings events and NamEventManager) command gets correctly disabled without issues.
Have not tested any other maps or mod combinations but also can't see any reason why other setups wouldn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants