-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NamalskEvents and use GetNamEventManager API #163
base: master
Are you sure you want to change the base?
Conversation
@Da0ne or @GravityWolfNotAmused you still working on this project? Does this seem acceptable change to make Namalsk events work again? Kind of works for me... thing is I have not actually tested changes to actual VPP-Admin-Tools mod but through adding another ChatCommand to manager from outside. So it should be exact same but I do not really have any DayZ modding experience so... Also issue why it does not work might actually be elsewhere, no idea but only one thing comes to mind: VPP-Admin-Tools/4_World/VPPAdminTools/Plugins/PluginBase/ChatCommandManager/ChatCommandManager.c Line 22 in 02bbfa3
If this check does not work then this PR also wouldn't fix anything and would just make it use that event manager wrapper. |
I'm doubtful this will succeed in testing with other maps; however, I'm looking at this from a phone in the car. If you took your changes and used it without namalsk, I'm pretty sure this will fail to compile. |
Well yeah, I guess I've fixed issue. This time actually verified at least some things instead of just throwing in code that worked elsewhere. And also like I thought problem wasn't actually event there but with But still have not actually tested changes to this mod, but I think it should work now. |
@GravityWolfNotAmused cleaned up a bit and tested, seems to work fine now. Does it look good now? |
Have you tested with and without namalsk? |
Tested with and without Namalsk Survival, both tests on Namalsk map. Without survival mod (which brings events and NamEventManager) command gets correctly disabled without issues. |
Does not work so make it work, this seems to work.