Merge #1
Open
Merge #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I31711d285772d3c4c3294e89e6fc267bc861cc66
Change-Id: I25b69ebab006e483a9edb9163d9cc9f21c1ce8ad
Changed Find command argument name to iname in command_list xml. square brackets and upper case format removed from searchHelper class Bug: CYNGNOS-2273 Change-Id: I40fe203929656055e209f10f6284c0b39634a6fb
Change-Id: I3b3fe97888a8bb87a981e97c1fefba668e58d545
Change-Id: Ia2dd94808f8ad9b7c3d60b48aeb23cda18219fc4
Issue-id: FEIJ-341 Change-Id: I6a418aa099569484fd6f95f2b8d0987b59eba2a9
Issue-id: FEIJ-372 Change-Id: Ibe58efe5b6cccad5dbaeb59031da9aa6afad7d1b
Issue-id: FEIJ-372 Change-Id: I723970725579004433d1ba8cadec55b49795987a
Issue-id: FEIJ-331 Change-Id: I7982dfc3c453518c2358b2118a13455e899023db
When "Use swipe gestures" is on, click on listview item has no effects. Since ev.getX() or ev.getY() is returning floating point, while the previous touch location is stored as fixed point. When there is fractional parts in getX(), it will always return false when it compares to the previous touch point, making the flinger logic to think the touch does moved while it is actually not. FEIJ-290 Change-Id: Ib208b6115c0758facf29461ef45f6ffd5c67adce
Issue-id: FEIJ-356 Change-Id: I918f62e42ecca8c7c51ff8edefdfcd3f78245b45
When switching between portrait and landscape modes, the icons view needs to be updated to re-arrange the icons based on updated width. Added a new method for refreshing icons view mode. This method is called during orientation changes. Issue-Id: FEIJ-492 Change-Id: I9c95357a7d4f57b223147e774838e4fdc19f5e89
Change-Id: I687a7f589c520b6caa36cc8e141453f9a091a89a
When user switches between different category types in the search results, any non-relevant entries should be filtered out. Added check for filtering out non-relevant search results. Issue-Id: FEIJ-517 Change-Id: I7f92819b362720d58860e41d7252cd43cbece808
Change-Id: I456ef4aff6025c983f016bb0950814f9620a8662
Ideally we would allow the properties action to appear and ask the user to unlock the directory first, but that seems to be nigh impossible without refactoring SecureConsole. Change-Id: If619062d3c3db1855ac865811cf6b48e5ae5812f issue-id: FEIJ-692
Fix disk usage for no categories If no categories are found, ensure we fallback to drawUsed so the graph represents the information correctly. FEIJ-650 Change-Id: Ifdc069b1266c96dc1dc2569a2c0d45146f96b73d
Without granting url read permission, the caller using the picker will encounter a security denied. FEIJ-809 Change-Id: I0ad564f7c16a36b4395f0d1d19d7eed10d0917c4
It just don't support it currently as it requires the UI to ask for password first. FEIJ-825 Change-Id: I7ef4199d99110652b3f13fe9fed8336bf07f59f4
NavigationView is null before permission is granted. Guard with a null checking before refreshing FEIJ-820 Change-Id: Ib778ec82ce49dbcad8e45a5d54a5501cd3030410
Change-Id: I2e50638e758fca25e32fad9d3e9c586bdfe8e25b
This patch fixes the file manager on android-n-preview-2 (and maybe other roms/systems). Observed behavior: no output is produced at StdIn or StdErr after writing commands to the shell console. This leads to a timeout and a reallocation of the console in an endless loop. Flushing the output stream fixes the problem. Not sure if there was a good reason for not doing it in general. Change-Id: Ia87aa5065f6c62f133de4bbde4b4a32a4388d784
Fix for the case when getExternalFilesDir returns null Change-Id: I62725cec0f65412f3cc9c66c0e9870d2da62c6b8
In M, we need to request permission the first time application is use it. And we put that before the creation of the content view. If screen rotated before user confirm the permission dialog box, it will cause onConfigurationChanged to be called, and refreshs the view which is not created yet. Add a null pointer checking to avoid that. FEIJ-1083 Change-Id: Ic3c762e62edef28d4c5d7a7a89fabec3f4324eca
If the use is in a sub settings, i.e. general settings, and changes their language. Upon returning to File Manager and pressing back to go to the main settings menu, the about text will remain in the previous language. This is easily reproduced when the intial language is set to Chinese and then switched to English. The about text will still be in Chinese. Change-Id: I1dff61a6a94e6aabf336d863e102c29044f3a649 (cherry picked from commit b35b682)
We don't support vnd.android.cursor mimetype, the return result is never be expected to caller. Ideally, we should filter that mimetype in AndroidManifest.xml, however we currently accept */* mimetype and there is no way to exclude a specific mimetype. FEIJ-1138 FEIJ-1140 FEIJ-1141 Change-Id: I407159c5f5283e4d5cec2ec129a7643723bc8602
ListPopupWindow doesn't appear to correctly recalculate its popup size after rotation. Force the recalculation on rotation and allow the window to fill the entire screen if necessary. FEIJ-1192 Change-Id: I6345a56c4dde3dd73c3d902afd0a840307014178
Change-Id: I6c7ba075b084892a30676d60b87c147ec1cc78c6
Change-Id: I883bd3587e91cfc6ee73eec45ea9840d781719bb (cherry picked from commit 76e0032)
We need to make sure that the list is the proper height so that it does not draw off the screen. Ideally, we would stop handling the orientation changes and allow the app to do the orientation changes as android apps do normally. This would require some significant changes to how our dialog system works and could cause other potential issues. Ticket: QRDL-882 Change-Id: I39176d56d8286ed93b71dbe4c770fe79f39ac753 (cherry picked from commit d86bee2)
Changed how the java console handles detecting if a file rename collides with another file to more represent how the particular filesystem implementation handles it (I'm looking at you vfat). Change-Id: I6ac9ae848ee47fa33f02225c310c92f2a03fb50d (cherry picked from commit bd4178a)
The logic was backward here. Instead, prompt the user if no permissions and start navigating if already granted. FEIJ-1389 Change-Id: Idee7024516eed5671bc7a1101fc812680db3447b
Instead of falling back to the editor activity as a last resort for "Send", remove the option if there's no potential candidate. The editor activity won't handle the ACTION_SEND/ACTION_SEND_MULTIPLE intent anyway. This stops an error from popping up in the editor if the file cannot be sent from any other activity. FEIJ-1380 Change-Id: I2330299e0cb8b6f3c93d5a190067b8bfe6a3f56f
FEIJ-1380 Change-Id: I93eea906f35dc5403349409b1c26e6a4fc386d5a
Commit 6f6094d does not do what it said. It said " We are now defaulting to treating 3GP files as video files for determining the default icon as it was parsing the video files for their metadata which was causing ANR problems." However it returns no icon for 3GP. Fix it to do what it said in that commit. FEIJ-202 FEIJ-1347 Change-Id: Ieb57583316594c0308792ff8b43aadf1b15d74a5
When long pressing a directory, the actions dialog will build an FSO send intent to query if it can be handled by any application. In this case, the list of URIs to share will be 0, causing the crash. FEIJ-1439 Change-Id: I3f500916774af4bde939bd42060d92070971663a
Toolbox ls does not include inode column, which causes parser to fail and not show directory size in properties dialog. CYNGNOS-3081 Change-Id: I8b0779404795be63de56bc1bc4a7dc46468fcb77
Change-Id: Ie23d9d06582ef26b0af2b20f9236d88521b1f0ac
mimeType can't be null here so just remove those checks and make the code more readable Change-Id: Ic1f6fde2c102912dd8fc7e783d86c2936c43316f
Change-Id: Ida2016632f73c3b7bc521ff074676c1b13327658 Ticket: -
Change-Id: I662728fcce58a8072d6b758998934cdc4cef2ed9 Ticket: -
Change-Id: I3426c86087450feae50d47ed7bafa5cf4fa8eba5 Ticket: -
Change-Id: Ie366dd1525d60a447fbfbe40b3b3cd222a8c136c Ticket: -
Change-Id: Idd833f7c590f01bf8cffd7c3886570ac3bfed0c1 Ticket: -
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.