Skip to content

Commit

Permalink
fix(remotewrite2): do not overwrite help text with unit in enqueue
Browse files Browse the repository at this point in the history
While testing POC for grafana/mimir#9072
I saw no unit or help metadata. Our test env:
https://github.com/grafana/mimir/tree/main/development/mimir-monolithic-mode
doesn't have units, so that was empty and cleared the help due to this bug.

Signed-off-by: György Krajcsovits <[email protected]>
  • Loading branch information
krajorama authored and Vandit1604 committed Jan 16, 2025
1 parent c1df738 commit ba76432
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion storage/remote/queue_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -1923,7 +1923,7 @@ func populateV2TimeSeries(symbolTable *writev2.SymbolsTable, batch []timeSeries,
if d.metadata != nil {
pendingData[nPending].Metadata.Type = writev2.FromMetadataType(d.metadata.Type)
pendingData[nPending].Metadata.HelpRef = symbolTable.Symbolize(d.metadata.Help)
pendingData[nPending].Metadata.HelpRef = symbolTable.Symbolize(d.metadata.Unit)
pendingData[nPending].Metadata.UnitRef = symbolTable.Symbolize(d.metadata.Unit)
nPendingMetadata++
}

Expand Down

0 comments on commit ba76432

Please sign in to comment.