fix(settings): Fixed issue with first time settings save

VanOns · Aug 23, 2024 · 59c30a3 · 59c30a3
1 parent ddedd72
commit 59c30a3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/Includes/SettingsPage.php b/Includes/SettingsPage.php
@@ -16,9 +16,8 @@ public static function registerSettings(): void
             'type' => 'array',
             'sanitize_callback' => function ($value) {
                 return array_map(function (string $type) use ($value) {
-                    return isset($value[$type]);
-                }, get_post_types(['public' => true])
-                );
+                    return isset($value[$type]) && $value[$type];
+                }, get_post_types(['public' => true]));
             },
             'default' => [
                 'post' => true

diff --git a/templates/admin/settings.php b/templates/admin/settings.php
@@ -3,7 +3,6 @@
         <?php settings_fields('vo-html-sitemap-settings') ?>
         <?php do_settings_sections('vo-html-sitemap') ?>
 
-
         <table class="form-table">
             <tr>
                 <th scope="row">
@@ -16,8 +15,7 @@
                         </legend>
                         <?php foreach (get_post_types(['public' => true]) as $type): ?>
                             <label>
-                                <input type="checkbox" name="vo-html-sitemap-post-types[<?php echo esc_attr( $type ) ?>]"
-                                       value="1" <?php echo checked(get_option('vo-html-sitemap-post-types')[$type] ?? false) ?>>
+                                <input type="checkbox" name="vo-html-sitemap-post-types[<?php echo esc_attr( $type ) ?>]" <?php echo checked(get_option('vo-html-sitemap-post-types')[$type] ?: false) ?>>
                                 <?php echo esc_html( get_post_type_object($type)->label ) ?>
                             </label>
                             <br>