Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update dependencies, add new README style #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ptrcksc
Copy link

@ptrcksc ptrcksc commented Aug 21, 2024

No description provided.

@ptrcksc ptrcksc requested a review from dnwjn August 27, 2024 13:16
@@ -1,3 +1,5 @@
<p align="center"><img height="300px" src="./logo-text.svg" alt="logo"></p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move all images used in the documentation to /art, as in the Open Source template?

@@ -1,3 +1,5 @@
<p align="center"><img height="300px" src="./logo-text.svg" alt="logo"></p>

# Block Editor

This package is a Work In Progress. It aims to seperate the Javascript frontend from [Laraberg](https://github.com/VanOns/laraberg) so it can be maintained seperately, and maybe serve as a starting point for other backend implementations.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Do we still need to define this package as a WIP?
  • Can this text possibly be modernized?

@@ -7,8 +9,54 @@ This package is a Work In Progress. It aims to seperate the Javascript frontend
To use the editor simply create a input or textarea element and use it to initalize it like this:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe formulate it as something like:

To use the editor, simply create an input or textarea element and use it to initalize:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants