Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OD-1773 Klaviyo email events for the Customer RMA operations #2

Open
wants to merge 1 commit into
base: 12.0
Choose a base branch
from
Open

OD-1773 Klaviyo email events for the Customer RMA operations #2

wants to merge 1 commit into from

Conversation

astirpe
Copy link

@astirpe astirpe commented May 18, 2022

No description provided.

@astirpe astirpe marked this pull request as ready for review May 19, 2022 10:19
@StefanRijnhart
Copy link

If the RMA move is linked to the sale line this way, I suspect that it might be the case that the delivered qty goes down of that sale line, which will make the sale order eligible for refund for lines that are invoiced by delivered quantity. Is that a problem for us, or for the upstream project if you intend to propose this there as well?

@StefanRijnhart
Copy link

Actually, this would only impact stock moves with to_refund = True, and I believe stock-rma has its own logic for that so linking the sale line here should not be a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkubiak789 dkubiak789 dkubiak789 approved these changes

@antonioburic antonioburic antonioburic approved these changes

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

@pankk pankk Awaiting requested review from pankk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@astirpe @StefanRijnhart @antonioburic @dkubiak789