Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getting stuck when clipping on diagonal geometry #3668

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AltimorTASDK
Copy link

Fixes issue #3586

@AltimorTASDK
Copy link
Author

Fix is at pm_shared/pm_shared.c:744, just realized there's a bunch of whitespace trimming.

@mlibre2
Copy link

mlibre2 commented Dec 3, 2023

Important

pitifully this repository stopped receiving mergers since 2014 to the public becoming outdated, @alfred-valve it seems to no longer belong to the teamauthorized the last one, all its latest current modifications are managed privately.

@pierow
Copy link

pierow commented Dec 7, 2023

I can confirm this significantly improves the issue. There is still some sticking on diagonal walls after applying this fix.

Using the example wall in the issue thread and 900fps to increase the frequency it occurs:

wallsticking.mp4

SaintWish added a commit to MSRevive/MasterSwordRebirth that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants