-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Export framework #220
Draft
Krzmbrzl
wants to merge
17
commits into
ValeevGroup:master
Choose a base branch
from
Krzmbrzl:export-framework
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krzmbrzl
force-pushed
the
export-framework
branch
2 times, most recently
from
July 10, 2024 13:36
1313e9b
to
bf68d73
Compare
Krzmbrzl
force-pushed
the
export-framework
branch
from
September 17, 2024 09:52
a727aa3
to
7f0cde0
Compare
The entire logic that was present to determine whether a given tensor is created or loaded and whether when it will be set to zero and when not is not also applicable to variables. This is in order to prevent a bug in which result variables would be loaded but not set to zero before their intended value is added to it.
This way, when inheriting from a given generator, it is still possible to pass a custom context class to the top-level Generator<> interface, which is required in order to make things play out nicely.
Krzmbrzl
force-pushed
the
export-framework
branch
from
September 17, 2024 10:08
7f0cde0
to
0a8c304
Compare
Support tensor contraction frameworks are - TensorOperations.jl - TensorKit.jl - ITensor.jl
Krzmbrzl
force-pushed
the
export-framework
branch
from
September 17, 2024 14:08
cded94a
to
a24970b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements (more or less) general code generator capabilities into SeQuant. The idea is to abstract the bulk of the work required during code generation away such that new languages can be added as easily as possible.
Note: At this point, I am mainly creating this PR to make everyone aware that I am working on something in that direction.