Fix split pruning for multiple iterative_steps#352
Draft
SPieterG wants to merge 1 commit intoVainF:masterfrom
Draft
Fix split pruning for multiple iterative_steps#352SPieterG wants to merge 1 commit intoVainF:masterfrom
SPieterG wants to merge 1 commit intoVainF:masterfrom
Conversation
Author
|
@VainF Looking at the ConcatPruner it seems to do the same with self.offsets but the test_concat.py already works even with iterative_steps = 5. Would you know what could be the difference that makes concat work but split fail or would it be failing in a hidden way? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SplitPruner updates self.offsets instead of layer.offsets causing index errors when using iterative_steps > 1
Reproducible by setting iterative_steps=2 in the test_concat_split.py and test_split.py tests