Bump pyright to 1.1.410 and drop now-unnecessary ignore comments#3216
Merged
Conversation
pyright 1.1.410 no longer reports torch.tensor as a private import, so the reportPrivateImportUsage suppressions are now flagged as unnecessary. Drop them and let ruff collapse the calls to single lines. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Required for the torch.tensor reportPrivateImportUsage suppressions to be correctly treated as unnecessary. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps pyright from 1.1.409 to 1.1.410. In 1.1.410 pyright no longer reports
torch.tensoras a private import, so the three# pyright: ignore[reportPrivateImportUsage]suppressions ontorch.tensor(...)calls became errors underreportUnnecessaryTypeIgnoreComment(the failure on PR #3213). This removes those comments and lets ruff collapse the calls to single lines. The bump and the comment removal must land together — either alone fails CI.🤖 Generated with Claude Code