Fixes memory leaks inside CoverageTool and improves style #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
includes several style improvements
DanielELog
force-pushed
the
CoverageToolFixes
branch
from
bc8bb89 to
02dfbfa
Compare
- adds destructors for classes and respective calls for them - provides a certain background for implementing test project collection in the future
DanielELog
force-pushed
the
CoverageToolFixes
branch
from
02dfbfa to
4eb6f3b
Compare
KarasssDev
suggested changes
May 28, 2024
| @@ -31,6 +31,9 @@ CorProfiler::~CorProfiler() | |||
|
|
|||
| HRESULT STDMETHODCALLTYPE CorProfiler::Initialize(IUnknown *pICorProfilerInfoUnk) | |||
| { | |||
| setbuf(stdout, NULL); | |||
There was a problem hiding this comment.
Не забыть удалить дебаг логи
Comment on lines
+73
to
+75
| std::vector<std::vector<char>> serializedCoverage; | ||
| std::mutex collectedMethodsMutex; | ||
| std::vector<MethodInfo> collectedMethods; |
Comment on lines
88
to
89
| return IsMain(moduleName, moduleSize, method) || (!profilerState->isTestExpected && !profilerState->collectMainOnly) | ||
| || (profilerState->isTestExpected && doesContainAssembly(assemblyName, assemblySize, profilerState->approvedAssemblies)); |
There was a problem hiding this comment.
Split into two variables
Comment on lines
16
to
25
| bool IsEnvVarPresent(const char *name) { | ||
| auto value = std::getenv(name); | ||
| return value != nullptr && value[0] == '1'; | ||
| } | ||
|
|
||
| char *CheckEnvVarAndGet(const char *name) { | ||
| auto str = std::getenv(name); | ||
| profiler_assert(str); | ||
| return str; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.