Skip to content

Fix requests #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 43 commits into
base: master
Choose a base branch
from
Open

Fix requests #451

wants to merge 43 commits into from

Conversation

SystemsPurge
Copy link
Contributor

A collection of fixes and refactoring changes to make frontend run smoother with redux
Includes refactoring into functional components, and adjustment of some breaking changes that happened with the migration

@SystemsPurge SystemsPurge linked an issue May 8, 2025 that may be closed by this pull request
Rewrite some or all of components to account for the flux to redux migration #441
Open
8 tasks
SystemsPurge and others added 29 commits May 8, 2025 09:37
@SystemsPurge
Fix IC creation bouncing issue
abf7efd 
Signed-off-by: SystemsPurge <[email protected]>
@Anyandsi @SystemsPurge
remove shutdown button from ic actions
94c906a 
Signed-off-by: Andrii Podriez <[email protected]>
Signed-off-by: SystemsPurge <[email protected]>
@Anyandsi @SystemsPurge
Add missing parameters when sending action to ic
1c3a800 
Signed-off-by: Andrii Podriez <[email protected]>
Signed-off-by: SystemsPurge <[email protected]>
@Anyandsi @SystemsPurge
Refactor PlayerWidget into a functional component
fdfe7b8 
Signed-off-by: Andrii Podriez <[email protected]>
Signed-off-by: SystemsPurge <[email protected]>
@SystemsPurge
fix: incomplete URL, remove useless files from rebase
9825122 
Signed-off-by: SystemsPurge <[email protected]>
@SystemsPurge
fix: status widget and player widget
957f55a 
Signed-off-by: SystemsPurge <[email protected]>
@SystemsPurge
Add hooks for activation and deactivation of player widget, on ic sta…
c83e6ca 
…te changes

Signed-off-by: SystemsPurge <[email protected]>
@SystemsPurge
fix: icstatus due to bouncing, player for responsiveness, python dial…
91a7c02 
…og for a slew specific endpoint

Signed-off-by: SystemsPurge <[email protected]>
@SystemsPurge
add: handling for missing use case in player widget
b815c07 
Signed-off-by: SystemsPurge <[email protected]>
@SystemsPurge
add: downtime for play button
79f34f7 
Signed-off-by: SystemsPurge <[email protected]>
@SystemsPurge
fix: duplicate widgets for duplicated scenarios
f24cb36 
Signed-off-by: SystemsPurge <[email protected]>
@SystemsPurge
Clean up logs
67a2f36 
Signed-off-by: SystemsPurge <[email protected]>
@SystemsPurge
add: start parameters update from within dashboard
181d2e8 
Signed-off-by: SystemsPurge <[email protected]>
@SystemsPurge
fix: wrong variable name
28db73e 
Signed-off-by: SystemsPurge <[email protected]>
@SystemsPurge
change: recreate action to recreate every managed component, includin…
df3c63e 
…g manager

Signed-off-by: SystemsPurge <[email protected]>
@SystemsPurge
Remove useless logging
063984f 
Signed-off-by: SystemsPurge <[email protected]>
@SystemsPurge
Transferr branding code to right branch
ac4671d 
Signed-off-by: SystemsPurge <[email protected]>
@SystemsPurge
Add missing branding cases in branding.js
9a5757b 
Signed-off-by: SystemsPurge <[email protected]>
@SystemsPurge
fix: mistake in ic type case enumeration
9d901b1 
Signed-off-by: SystemsPurge <[email protected]>
@SystemsPurge
Fix readonly widget.customProperties, add websocketSlice reducer and …
301ceb8 
…state for values array per dashboard

Signed-off-by: SystemsPurge <[email protected]>
@SystemsPurge
Add enershare branding
e2ec45d 
Signed-off-by: SystemsPurge <[email protected]>
@SystemsPurge
Make widget component report initial values without simStart
755ea39 
Signed-off-by: SystemsPurge <[email protected]>
@SystemsPurge
Add enershare branding to build CI
6b63625 
Signed-off-by: SystemsPurge <[email protected]>
@Anyandsi @SystemsPurge
Update modal for the ICs creation
f81051e 
Signed-off-by: Andrii Podriez <[email protected]>
Signed-off-by: SystemsPurge <[email protected]>
@Anyandsi @SystemsPurge
Fix small typo in a comment
050efe8 
Signed-off-by: Andrii Podriez <[email protected]>
Signed-off-by: SystemsPurge <[email protected]>
@Anyandsi @SystemsPurge
Add error boundary to the dashboard and start refactoring
c06b16c 
Signed-off-by: Andrii Podriez <[email protected]>
Signed-off-by: SystemsPurge <[email protected]>
@Anyandsi @SystemsPurge
Change widget context menu into a functional component
faae8b1 
Signed-off-by: Andrii Podriez <[email protected]>
Signed-off-by: SystemsPurge <[email protected]>
@Anyandsi @SystemsPurge
Update refactored widget behavior
a20c86a 
Signed-off-by: Andrii Podriez <[email protected]>
Signed-off-by: SystemsPurge <[email protected]>
@Anyandsi @SystemsPurge
Fix wrong ic modal type/category filtration
6f87dfa 
Signed-off-by: SystemsPurge <[email protected]>
Anyandsi and others added 7 commits May 8, 2025 09:37
@Anyandsi @SystemsPurge
add error boundary to the dashboard refactor widgets and dashboard co…
3247cce 
…mponents

Signed-off-by: Andrii Podriez <[email protected]>
Signed-off-by: SystemsPurge <[email protected]>
@Anyandsi @SystemsPurge
add Kopernikus branding
3a274c1 
Signed-off-by: Andrii Podriez <[email protected]>
Signed-off-by: SystemsPurge <[email protected]>
@Anyandsi @SystemsPurge
remove new branding from the wrong branch
7e538ac 
Signed-off-by: Andrii Podriez <[email protected]>
Signed-off-by: SystemsPurge <[email protected]>
@Anyandsi @SystemsPurge
transfer dashboard and widgets changes to a new branch
f65502e 
Signed-off-by: Andrii Podriez <[email protected]>
Signed-off-by: SystemsPurge <[email protected]>
@Anyandsi @SystemsPurge
Update Button Widget
38e1361 
Implement toggle mode
Adjust size of the box for the WidgetPlayer

Signed-off-by: Andrii Podriez <[email protected]>
Signed-off-by: SystemsPurge <[email protected]>
@SystemsPurge
fix: duplicate/missing declarations in multiple files
7f019bb 
Signed-off-by: SystemsPurge <[email protected]>
@SystemsPurge
remove useless code
ed8a623 
Signed-off-by: SystemsPurge <[email protected]>
@SystemsPurge SystemsPurge requested a review from iripiri May 8, 2025 08:04
@stv0g
Copy link
Contributor

stv0g commented May 8, 2025

Thats pretty difficult or almost impossible to review for me :(

I just hope it does not break stuff..

I would welcome if we can return to better review practices in the VILLAS repos: Small PRs addressing one issue at a time.

@SystemsPurge
Copy link
Contributor Author

SystemsPurge commented May 8, 2025 •
edited
Loading

@stv0g this is not meant to be the continous practice. It is unorganized due to being a collection of small fixes to exactly avoid a couple breaking changes.
The changes were reviewed when they were initially merged with the fix-requests branch from a fork.
As for the concern about the breaking change, i will shortly give you credentials to a test deployment if you want and you can test it out yourself...
As far as i noticed when i reviewed the PR from the fork to the branch, there were not any.
"Small PRs addressing one issue at a time." is definitely the plan, but keep in mind that there is a couple more things that need to be cleaned up first, and they might be spread across different contexts ( despite having to do with the same issue )

EDIT: if it is ABSOLUTELY an issue, i can squash some

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iripiri iripiri Awaiting requested review from iripiri

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite some or all of components to account for the flux to redux migration
3 participants
@SystemsPurge @stv0g @Anyandsi