Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 54 add pca #56

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Feature 54 add pca #56

wants to merge 6 commits into from

Conversation

asizemore
Copy link
Member

@asizemore asizemore commented Jan 3, 2025

Resolves #54

Adds pca method. This method wraps prcomp. Not much else to say!

To do:

  • main function
  • basic tests
  • test with messy data
  • Change the output to a ComputeResult. Originally i wanted just a data.table for simplicity. But after starting to wire it up it'd be slightly more helpful if the pca output had some extra info.

@asizemore asizemore requested a review from bobular January 10, 2025 21:25
@asizemore asizemore marked this pull request as ready for review January 10, 2025 21:27
@asizemore asizemore removed the request for review from bobular January 13, 2025 14:32
@asizemore
Copy link
Member Author

@bobular i decided to change the output a bit, so i removed you from the reviewers list. I'll update here when it's ready again.

@asizemore asizemore marked this pull request as draft January 13, 2025 14:32
@asizemore
Copy link
Member Author

@bobular ready for you to take a look! Not in a rush.
I'll be using this branch to draft a new viz plugin on the backend.

@asizemore asizemore marked this pull request as ready for review January 17, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PCA
1 participant