Impute zeroes variable collections #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asizemore
reviewed
Aug 31, 2023
| @@ -122,16 +142,54 @@ findEntityIdColumnNameForVariableSpec <- function(varSpec, entityIdColumns) { | |||
| return(entityIdColumns[grepl(varSpec@entityId, entityIdColumns)]) | |||
| } | |||
|
|
|||
| findStudyVocabularyByVariableSpec <- function(vocabs, variableSpec) { | |||
| findStudyVocabularyByVariableSpec <- function(vocabs, variables, variableSpec) { | |||
There was a problem hiding this comment.
seems like this and the previous function should be s4 methods since we're going through the trouble of checking their classes? Not urgent but for the future
| return(varSpecsWithVocabs) | ||
| } | ||
|
|
||
| getVariableColumnNames <- function(variableMetadata) { |
d-callan
commented
Sep 6, 2023
| hasStudyDependentVocabulary = TRUE, | ||
| members = VariableSpecList(S4Vectors::SimpleList(VariableSpec(variableId='pathogen_presence', entityId='assay'), | ||
| VariableSpec(variableId='pathogen2_presence', entityId='assay'), | ||
| VariableSpec(variableId='pathogen3_presence', entityId='assay'))) |
There was a problem hiding this comment.
i think i need a test where i have a collection, but the OTHER var is the one w the special vocab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oops. forgot about collections when i built the impute zeroes helper..