Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PROJECT_NAME to override in all cases in wb script #77

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bobular
Copy link
Member

@bobular bobular commented Oct 14, 2021

I (Bob) found a problem with the wb script when running different branded sites from /var/www/EuPathDB/eupathdb.bmaccallum

rebuilder worked fine, but this fix stops the wdkXml step failing.

@bobular bobular requested a review from jbrestel October 14, 2021 16:21
Copy link
Member

@jbrestel jbrestel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if it makes sense to force the user to set the PROJECT_NAME environment variable? That way there is no confusion. (or maybe print a warning if it is getting the project name from tomcat directory name)

@bobular
Copy link
Member Author

bobular commented Oct 15, 2021

Sure - we should make sure the behaviour of rebuilder and wb are the same. I'm not yet familiar with the former. I see it calls install/bin/build.pl which is a wrapper for ant, but also mentions maven. Not sure where the ant XML file is? 🤯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants