Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SideBarWidget) add 3DTiles loading feedbacks #651

Merged

Conversation

valentinMachado
Copy link
Contributor

Add feebacks of the 3DTiles loading (an ui element and some box3 in the scene)

Depends of this PR

@valentinMachado valentinMachado self-assigned this May 10, 2023
@valentinMachado valentinMachado linked an issue May 10, 2023 that may be closed by this pull request
1 task
@valentinMachado valentinMachado marked this pull request as draft May 10, 2023 17:45
@valentinMachado valentinMachado force-pushed the 236-information-that-an-3d-object-is-being-loaded branch from e75791a to 3026ceb Compare June 26, 2023 12:12
@valentinMachado valentinMachado marked this pull request as ready for review June 26, 2023 12:13
@valentinMachado
Copy link
Contributor Author

in order to test this feature you could have to remove the loading screen

@clementcolin
Copy link
Contributor

Indeed, loading screen needs to be removed to visualize this feature.

It seems that the UI element disappears when one tile has been loaded in the scene, should it not wait for all tiles to be loaded before disappearing?
Also, I could not see the 3D elements in the scene that show a tile loading (from what I understand, it should be a cube that uses the bounding box of the tile being loaded)

Does Itowns wait for a tile to be loaded before requesting another ? If not, should we not display multiple 3D object for each loading tile ?

@valentinMachado
Copy link
Contributor Author

valentinMachado commented Jun 27, 2023

Indeed, loading screen needs to be removed to visualize this feature.

I've created a dedicated example to visualize this feature

It seems that the UI element disappears when one tile has been loaded in the scene, should it not wait for all tiles to be loaded before disappearing?

yes if there is still one tile which has been requested and not loaded the ui element should remains, this is working on my camputed though

Also, I could not see the 3D elements in the scene that show a tile loading (from what I understand, it should be a cube that uses the bounding box of the tile being loaded)

yes that's the behavior expected also working on my computer though

Does Itowns wait for a tile to be loaded before requesting another ?

No tiles are requested simultaneously depending of the culling test function

If not, should we not display multiple 3D object for each loading tile ?

That's should be the case...

Have you run an npm i to update with the last itowns version ? If yes could you try to reproduce behaviors you are describing with the new example

@clementcolin
Copy link
Contributor

Yay, it works fine now :) I do not understand how it worked before without the event.tile_requested though.

@valentinMachado valentinMachado force-pushed the 236-information-that-an-3d-object-is-being-loaded branch from b88b943 to 7ec0779 Compare July 11, 2023 13:59
@valentinMachado valentinMachado force-pushed the 236-information-that-an-3d-object-is-being-loaded branch from 7ec0779 to afaf40d Compare July 17, 2023 14:47
@valentinMachado valentinMachado merged commit 94ce5e9 into master Jul 17, 2023
@valentinMachado valentinMachado deleted the 236-information-that-an-3d-object-is-being-loaded branch July 17, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Information that an 3D object is being loaded
2 participants