-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SideBarWidget) add 3DTiles loading feedbacks #651
feat(SideBarWidget) add 3DTiles loading feedbacks #651
Conversation
e75791a
to
3026ceb
Compare
in order to test this feature you could have to remove the loading screen |
Indeed, loading screen needs to be removed to visualize this feature. It seems that the UI element disappears when one tile has been loaded in the scene, should it not wait for all tiles to be loaded before disappearing? Does Itowns wait for a tile to be loaded before requesting another ? If not, should we not display multiple 3D object for each loading tile ? |
I've created a dedicated example to visualize this feature
yes if there is still one tile which has been requested and not loaded the ui element should remains, this is working on my camputed though
yes that's the behavior expected also working on my computer though
No tiles are requested simultaneously depending of the culling test function
That's should be the case... Have you run an |
Yay, it works fine now :) I do not understand how it worked before without the event.tile_requested though. |
b88b943
to
7ec0779
Compare
7ec0779
to
afaf40d
Compare
Add feebacks of the 3DTiles loading (an ui element and some box3 in the scene)
Depends of this PR