Exhibit show #128
Merged
Exhibit show #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mathieuLivebardon
commented
Mar 4, 2022
•
mathieuLivebardon
commented
- Best popup og image GOs
- Image in big and without deformation, litle text of description, map of Lyon with Location of the image (if specified)
- All this elements are modifiable in the editor
- Doubleclick for display popup
- New Images and reorder them in the room Expo
- New image of the map of Lyon (free usage and georeferenced)
- Image respect by default its apsect ratio
- popup_position removed (old way to give a position in map for localize image). Now we works with GPS Coordinates (Lng, Lat)
- eslint-prettier-config (prevents conflicts between eslint and prettier)
| ] | ||
| }, | ||
| { | ||
|
|
client/assets/worlds/worlds.json
Outdated
| ] | ||
| }, | ||
| { | ||
|
|
| this.content.appendChild(labelFactorWidth); | ||
|
|
||
| this.content.appendChild(refresh); | ||
|
|
||
| } | ||
|
|
||
| appendLSSignageDisplayerUI(gV) { |
There was a problem hiding this comment.
each module function should be in a separate file to clear code
Closed
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.