Skip to content

Conversation

liondon
Copy link

@liondon liondon commented Apr 29, 2025

It’s causing false alert when there’s force push:

Error: The head commit for this pull_request event is not ahead of the base commit. Please submit an issue on this action's GitHub repo.

See jitterbit@54f3703:

Remove response.data.status check
It's perfectly valid for a head to be "behind" a base when comparing commits for pull request events. For example, PRing a feature branch of main while other commits have landed on main after the feature branch was started but before the PR was created, or a PR to merge a "development" branch onto a slower moving "release" branch that has some hotfixes on it.

Also see jitterbit#4

It’s causing false alert when there’s force push:
```
Error: The head commit for this pull_request event is not ahead of the base commit. Please submit an issue on this action's GitHub repo.
```

See jitterbit@54f3703
@liondon liondon requested a review from a team as a code owner April 29, 2025 18:29
@liondon
Copy link
Author

liondon commented Apr 29, 2025

postponing merging the change because this repo seems a bit problematic:

  1. no access to HM jira check action:
[Invalid workflow file: .github/workflows/jira.yml#L11](https://github.com/UseFedora/retrieve-changed-files/actions/runs/14738639414/workflow)
error parsing called workflow
".github/workflows/jira.yml"
-> "Hotmart-Org/actions/.github/workflows/jira.yaml@master"
: workflow was not found. See https://docs.github.com/actions/learn-github-actions/reusing-workflows#access-to-reusable-workflows for more information.
  1. It doesn't seem like we've ever pushed a new release ourselves, the forked action for publish seems worrying:
    https://github.com/actions/publish-action?tab=readme-ov-file#publish-action
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants