-
Notifications
You must be signed in to change notification settings - Fork 17
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
17 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,26 @@ | ||
# CRAN notes for dodgr_0.1.1 submission | ||
|
||
The only NOTE generated is "GNU make is a SystemRequirements", which is | ||
unavoidable because of the need to remove compiled object files in src | ||
sub-directories. | ||
## Notes | ||
|
||
This submissions generates the following NOTES on some systems: | ||
|
||
* One possibly invalid URL for a vignette reference, due to jstor preventing | ||
automated queries. The URL is nevertheless valid. | ||
* Package size slightly only 5MB, because of large doc and libs directories. I | ||
will endeavour to reduce this in future versions. | ||
* "GNU make is a SystemRequirements", which is unavoidable because of the need | ||
to remove compiled object files in src sub-directories. | ||
|
||
## Test environments | ||
|
||
This submission generates NO notes on: | ||
Other than the above, this submission generates no additional notes, and no | ||
warnings on: | ||
* Ubuntu 14.04 (on `travis-ci`): R-release, R-devel | ||
* Windows Visual Studio 2015 (on `appveyor`; `x64`): R-release, R-devel | ||
* win-builder (R-release, R-devel, R-oldrelease) | ||
* Package also checked using `rocker/r-devel-san` with clean results. | ||
* local valgrind --memcheck gives clean results | ||
|
||
Compiling with clang++ -Weverything generates only three types of warnings about | ||
(i) non-compliance with C++98; (ii) byte padding to align objects/boundaries; | ||
and (iii) out-of-line virtual method definitions that are raised by class | ||
destructors only and reflect desirable behaviour here. | ||
## valgrind memory leak | ||
|
||
Testing with "valgrind --tool=memcheck --leak-check=full" reveals one potential | ||
memory leak of around 2,000 bytes. This is due to RcppParallel and not code | ||
within this submission; see https://github.com/RcppCore/RcppParallel/issues/81 |