Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use poetry as package manager #326

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Use poetry as package manager #326

wants to merge 18 commits into from

Conversation

Minigrim0
Copy link
Member

@Minigrim0 Minigrim0 commented Dec 6, 2021 •
edited
Loading

Closes #366

TODO :

  • All all the needed requirements
  • Remove old files
  • Update the README/DEVELOPMENT
  • Update action script with poetry

@Minigrim0 Minigrim0 added enhancement dependencies Pull requests that update a dependency file labels Dec 6, 2021
@Minigrim0 Minigrim0 self-assigned this Dec 6, 2021
@Bruno-brsy
Copy link
Contributor

Je n'ai aucune idée de comment fonctionne poetrymoi :/

@Minigrim0
Copy link
Member Author

Je n'ai aucune idée de comment fonctionne poetrymoi :/

Je ferai une explication dans le readme :)

@Bruno-brsy
Copy link
Contributor

Je n'ai aucune idée de comment fonctionne poetrymoi :/

Je ferai une explication dans le readme :)

Ho ouais, trop bien, merci :)

C4ptainCrunch
C4ptainCrunch reviewed Jan 4, 2022
View reviewed changes
Copy link
Member

@C4ptainCrunch C4ptainCrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai pas trop d'XP avec poetry donc je sais pas trop donner mon avis (à part que ça fait un tool de plus à apprendre). Si jamais vous mergez, ça fait pas double emploi avec les requirements.txt et tout ça ?

@Bruno-brsy
Copy link
Contributor

J'ai pas trop d'XP avec poetry donc je sais pas trop donner mon avis (à part que ça fait un tool de plus à apprendre). Si jamais vous mergez, ça fait pas double emploi avec les requirements.txt et tout ça ?

Je me demande si ça ne peut pas remplacer le requirements.txt justement

@Minigrim0
Copy link
Member Author

C'est ça le but oui, ça unifie les requirements.txt, requirements-dev.txt et tout ce qui est config de tools (setup.cfg), ...

@Bruno-brsy
Copy link
Contributor

Ho, cool

@Mortinat Mortinat mentioned this pull request Jul 7, 2022
Open
@Mortinat Mortinat marked this pull request as ready for review July 7, 2022 16:02
@Mortinat
Copy link
Contributor

@Minigrim0 the test are okay now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C4ptainCrunch C4ptainCrunch C4ptainCrunch left review comments

@Bruno-brsy Bruno-brsy Awaiting requested review from Bruno-brsy

@Mortinat Mortinat Awaiting requested review from Mortinat

At least 1 approving review is required to merge this pull request.

Assignees

@Minigrim0 Minigrim0

Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use poetry instead of pip-compile
4 participants
@Minigrim0 @Bruno-brsy @Mortinat @C4ptainCrunch