Conversation
|
Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process. |
|
Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process. |
|
With the conflicts - I've assumed that the second one was generally the one we wanted. @danielrazavi Would you mind taking a quick look sometime this week please as a second reviewer please? |
danielrazavi
left a comment
danielrazavi
left a comment
There was a problem hiding this comment.
Everything looks great to me! I noticed a small dependency on @dtxe's repositories. For improved future-proofing, it might be better to transfer this dependency to our own org instead, but I defer to @RohanAlexander judgement.
3 participants
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)