Skip to content

submit assignment 1 #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

submit assignment 1 #191

wants to merge 1 commit into from

Conversation

MauxFear
Copy link

@MauxFear MauxFear commented Mar 8, 2025

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

I completed the assignment 1 for the LCR module.

What did you learn from the changes you have made?

I learn how to prepare data and the KNN classifier

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

I would like to test other classification algorithms such SVM and evaluate which algorithm works better. I think I can use the sklearn implementation for the SVM algorithm ( sklearn.svm)

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

I noticed that we need to add the class variable before the splitting. Otherwise, it would be an error due to the random shuffling and splitting of the data. I have to add the class variable and then do the splitting.

How were these changes tested?

I run the jupyter notebook

A reference to a related issue in your repository (if applicable)

Checklist

  • [ X ] I can confirm that my changes are working as intended

@MauxFear MauxFear closed this Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant