remove a bunch of unused variables for eslint #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for glittery-kulfi-b3068d failed.
|
kira-m
force-pushed
the
km-eslint
branch
2 times, most recently
from
57e3810
to
243342e
Compare
royayush1
previously approved these changes
Sep 28, 2023
royayush1
requested changes
Sep 29, 2023
| const [isLoading, setIsLoading] = useState(true); | ||
| const { currentUser, sessionToken } = useAuth(); | ||
| const [dishesUsed, setDishesUsed] = useState([]); | ||
| const [isMobile, setIsMobile] = useState(window.innerWidth <= 768); | ||
| const [isMobile, setIsMobile] = useState(window.innerWidth <= 768); // eslint-disable-line @typescript-eslint/no-unused-vars |
There was a problem hiding this comment.
I think we do need this for styling - coz the app can run both on the desktop browser or mobile
There was a problem hiding this comment.
@royayush1 yep I didn't take the line out!
// eslint-disable-line @typescript-eslint/no-unused-vars tells eslint "I know that this line is violating the no-unused-vars rule but please ignore it"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify build was failing due to
@typescript-eslint/no-unused-vars; this should put it back into a good state