Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added cstdint header to Register.hh #427

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Added cstdint header to Register.hh #427

merged 2 commits into from
Sep 20, 2024

Conversation

FinnWilkinson
Copy link
Contributor

Adds the cstdint header to Register.hh, which has caused some compilers to not recognise the uint8_t etc types.
As per Issue #426

@FinnWilkinson FinnWilkinson added the bug Something isn't working label Sep 3, 2024
@FinnWilkinson FinnWilkinson self-assigned this Sep 3, 2024
dANW34V3R
dANW34V3R previously approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@dANW34V3R dANW34V3R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think GitHub is complaining about the EOF but not an issue

@FinnWilkinson FinnWilkinson merged commit b73c2cc into dev Sep 20, 2024
2 checks passed
@FinnWilkinson FinnWilkinson deleted the missing_cstdint_header branch September 20, 2024 08:38
ABenC377 pushed a commit that referenced this pull request Oct 16, 2024
@FinnWilkinson @ABenC377
Added cstdint header to Register.hh (#427)
7cf58ba
@FinnWilkinson FinnWilkinson mentioned this pull request Oct 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ABenC377 ABenC377 ABenC377 approved these changes

@JosephMoore25 JosephMoore25 JosephMoore25 approved these changes

@jj16791 jj16791 jj16791 approved these changes

@dANW34V3R dANW34V3R dANW34V3R approved these changes

Assignees

@FinnWilkinson FinnWilkinson

Labels
bug Something isn't working
Projects
SimEng Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FinnWilkinson @dANW34V3R @jj16791 @JosephMoore25 @ABenC377