Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prevent fetch on init #56

Merged
merged 8 commits into from
Jan 2, 2025
Merged

feat: prevent fetch on init #56

merged 8 commits into from
Jan 2, 2025

Conversation

kwasniew
Copy link
Collaborator

@kwasniew kwasniew commented Jan 2, 2025

About the changes

Prevent fetching flags on init when storage has recent data (TTL not expired). This is a port of JS version Unleash/unleash-proxy-client-js#224

Important:

  • I'm using base64 encoding instead of sha256 hashing as in the JS version. It doesn't require any crypto libraries and we still store the flags in storage as plain text

Important files

Discussion points

@kwasniew kwasniew merged commit 93cd19f into main Jan 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants