fix: skip initial fetch with context (#60)

CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.9.2
+
+* Fix: Skip initial toggles fetch when using updateContext or setContextFields
+
 ## 1.9.1
 
 * Chore: Upgrade event_emitter version

example/lib/main.dart

@@ -1,5 +1,6 @@
 import 'package:flutter/material.dart';
 import 'package:unleash_proxy_client_flutter/unleash_proxy_client_flutter.dart';
+import 'package:unleash_proxy_client_flutter/unleash_context.dart';
 
 void main() {
   WidgetsFlutterBinding.ensureInitialized();
@@ -41,8 +42,12 @@ class _MyHomePageState extends State<MyHomePage> {
     var unleash = UnleashClient(
         url: Uri.parse('https://sandbox.getunleash.io/enterprise/api/frontend'),
         clientKey: 'SDKIntegration:development.f0474f4a37e60794ee8fb00a4c112de58befde962af6d5055b383ea3',
-        refreshInterval: 30,
+        refreshInterval: 10,
+        experimental: const ExperimentalConfig(togglesStorageTTL: 60),
         appName: 'example-flutter-app');
+    unleash.updateContext(UnleashContext(
+        userId: '123',
+        ));
     void updateCounterEnabled(_) {
       final counterEnabled = unleash.isEnabled('counter');
       setState(() {

example/pubspec.lock

@@ -355,7 +355,7 @@ packages:
       path: ".."
       relative: true
     source: path
-    version: "1.9.0"
+    version: "1.9.2"
   uuid:
     dependency: transitive
     description:

lib/unleash_proxy_client_flutter.dart

@@ -157,7 +157,7 @@ class UnleashClient extends EventEmitter {
       this.customHeaders = const {},
       this.impressionDataAll = false,
       // bump on each release, overwrite in tests, do not change in client code
-      this.sdkName = '[email protected].1',
+      this.sdkName = '[email protected].2',
       this.experimental}) {
     _init();
     metrics = Metrics(
@@ -204,8 +204,6 @@ class UnleashClient extends EventEmitter {
 
     if (bootstrap != null) {
       await _storeLastRefreshTimestamp();
-    } else {
-      lastRefreshTimestamp = await _getLastRefreshTimestamp();
     }
 
     clientState = ClientState.initialized;
@@ -355,7 +353,12 @@ class UnleashClient extends EventEmitter {
 
   Future<void> setContextFields(Map<String, String> fields) async {
     if (!_anyFieldHasChanged(fields)) return;
-    if (clientState == ClientState.ready) {
+    if (started == false) {
+      await _waitForEvent('initialized');
+      fields.forEach((field, value) {
+        _updateContextField(field, value);
+      });
+    } else if (clientState == ClientState.ready) {
       fields.forEach((field, value) {
         _updateContextField(field, value);
       });
@@ -456,6 +459,8 @@ class UnleashClient extends EventEmitter {
 
     metrics.start();
 
+    lastRefreshTimestamp = await _getLastRefreshTimestamp();
+
     if (!_isUpToDate()) {
       await _fetchToggles();
     }

pubspec.yaml

@@ -3,7 +3,7 @@ description: A Flutter/Dart client that can be used together with the unleash-pr
 homepage: https://github.com/Unleash/unleash_proxy_client_flutter
 repository: https://github.com/Unleash/unleash_proxy_client_flutter
 issue_tracker: https://github.com/Unleash/unleash_proxy_client_flutter
-version: 1.9.1
+version: 1.9.2
 
 environment:
   sdk: ">=2.18.0 <4.0.0"

test/unleash_proxy_client_flutter_test.dart

@@ -454,6 +454,68 @@ void main() {
     expect(anotherGetMock.calledTimes, 1);
   });
 
+  test('skip initial fetch when context is identical with updateContext',
+      () async {
+    final getMock = GetMock();
+    final sharedStorageProvider = InMemoryStorageProvider();
+    final unleash = UnleashClient(
+        url: url,
+        clientKey: 'proxy-123',
+        appName: 'flutter-test',
+        storageProvider: sharedStorageProvider,
+        fetcher: getMock,
+        experimental: const ExperimentalConfig(togglesStorageTTL: 10));
+    unleash.updateContext(UnleashContext(userId: '123'));
+
+    await unleash.start();
+
+    final anotherGetMock = GetMock();
+    final anotherUnleash = UnleashClient(
+      url: url,
+      clientKey: 'proxy-123',
+      appName: 'flutter-test',
+      storageProvider: sharedStorageProvider,
+      fetcher: anotherGetMock,
+      experimental: const ExperimentalConfig(togglesStorageTTL: 10),
+    );
+    anotherUnleash.updateContext(UnleashContext(userId: '123'));
+
+    await anotherUnleash.start();
+
+    expect(anotherGetMock.calledTimes, 0);
+  });
+
+  test('skip initial fetch when context is identical with setContextFields',
+      () async {
+    final getMock = GetMock();
+    final sharedStorageProvider = InMemoryStorageProvider();
+    final unleash = UnleashClient(
+        url: url,
+        clientKey: 'proxy-123',
+        appName: 'flutter-test',
+        storageProvider: sharedStorageProvider,
+        fetcher: getMock,
+        experimental: const ExperimentalConfig(togglesStorageTTL: 10));
+    unleash.setContextFields({'userId': '123'});
+
+    await unleash.start();
+
+    final anotherGetMock = GetMock();
+    final anotherUnleash = UnleashClient(
+      url: url,
+      clientKey: 'proxy-123',
+      appName: 'flutter-test',
+      storageProvider: sharedStorageProvider,
+      fetcher: anotherGetMock,
+      experimental: const ExperimentalConfig(togglesStorageTTL: 10),
+    );
+    anotherUnleash.setContextFields({'userId': '123'});
+
+    await anotherUnleash.start();
+
+    expect(anotherGetMock.calledTimes, 0);
+  });
+
   test('do not skip initial fetch when TTL exceeded', () async {
     final getMock = GetMock();
     final sharedStorageProvider = InMemoryStorageProvider();