chore: add change request events to teams integration #9309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunogois
requested review from
ivarconr,
chriswk,
daveleek and
thomasheartman
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
daveleek
approved these changes
Feb 13, 2025
daveleek
reviewed
Feb 14, 2025
| @@ -23,6 +41,26 @@ export default class TeamsAddon extends Addon { | |||
| flagResolver: IFlagResolver; | |||
|
|
|||
| constructor(args: IAddonConfig) { | |||
| if (args.flagResolver.isEnabled('teamsIntegrationChangeRequests')) { | |||
| teamsDefinition.events = [ | |||
There was a problem hiding this comment.
This is the only place the teamsDefinition is used yeah?
There was a problem hiding this comment.
Just double checked: Yes.
daveleek
approved these changes
Feb 14, 2025
nunogois
deleted the
chore-add-change-request-events-to-teams-integration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-3265/investigate-teams-integration-for-change-request-notifications
Adds change request events to the Teams integration.