fix: Add strategy and more strategies button are different heights #9300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Tymek
approved these changes
Feb 12, 2025
thomasheartman
deleted the
fix(1-3364)/make-more-stratgies-buttons-the-same-size
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the height discrepancy between add strategy and more strategies buttons, both with and without the flag enabled.
The essence of the fix is to make the "more strategies" button's height dynamic and grow to match the height of the other button.
Before (flag enabled):
After (flag enabled):
Before (flag disabled):
After (flag disabled):
As a bonus: also enables the ui font redesign flag for server-dev.
If you're very sharp-eyed, you might notice a few things:
There's more padding on the new button. This was done in concert with UX when we noticed there was more padding on other buttons. So as a result, we set the button type to the default instead of "small".
The kebab button isn't perfectly square with the flag on. There's a few issues here, but essentially: to use
aspect-ratio: 1, you need either a height or a width set. Because we want everything here to be auto-generated (use the button's intrinsic height), I couldn't make it work. In the end, I think this is close enough. If you have other ideas, you're very welcome to try and fix it.