feat: connection count usage #9294
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
| @@ -40,6 +42,46 @@ export const toChartData = ( | |||
| return { datasets, labels }; | |||
| }; | |||
|
|
|||
| export const toConnectionChartData = ( | |||
There was a problem hiding this comment.
this is a copy of existing method with minor modifications
| const date = parseISO(dataPoint.period); | ||
| const requestCount = dataPoint.trafficTypes[0].count; | ||
|
|
||
| if (dataPoint.period.length === 7) { |
There was a problem hiding this comment.
if YYYY-MM then divide requests by 1 day connection (7200 req) and number of days in a month
There was a problem hiding this comment.
whew. yeah, this'll work, but it feels iffy. A regex match ([0-9]{4}-[0-9]{2}) or a date checker would put me more at ease, but it'll also be more computationally expensive.
But even better: may I suggest that you do if (traffic.grouping === 'monthly)`? That should also give you what you need, and is also less work .
There was a problem hiding this comment.
| if (dataPoint.period.length === 7) { | |
| if (traffic.grouping === 'monthly') { |
| requestCount / (daysInMonth * 7200); | ||
| } else { | ||
| // 1 connection = 7200 requests per day | ||
| record[dataPoint.period] = requestCount / 7200; |
There was a problem hiding this comment.
daily request quota for one connection is 7200
There was a problem hiding this comment.
next PR may change the 7200 to a variant to make it configurable
| // console.log(chartData, chartDataSelection.grouping, chartDataSelection); | ||
|
|
There was a problem hiding this comment.
probably don't need this 😉
| const date = parseISO(dataPoint.period); | ||
| const requestCount = dataPoint.trafficTypes[0].count; | ||
|
|
||
| if (dataPoint.period.length === 7) { |
There was a problem hiding this comment.
whew. yeah, this'll work, but it feels iffy. A regex match ([0-9]{4}-[0-9]{2}) or a date checker would put me more at ease, but it'll also be more computationally expensive.
But even better: may I suggest that you do if (traffic.grouping === 'monthly)`? That should also give you what you need, and is also less work .
| const date = parseISO(dataPoint.period); | ||
| const requestCount = dataPoint.trafficTypes[0].count; | ||
|
|
||
| if (dataPoint.period.length === 7) { |
There was a problem hiding this comment.
| if (dataPoint.period.length === 7) { | |
| if (traffic.grouping === 'monthly') { |
|
Also, so this only affects visualisations, right? It's not supposed to touch the aggregation metrics in the boxes etc? Because if so, you probably want to do it earlier on. |
|
@thomasheartman yeah, i deliberately left out the aggregation box since this change is to get a preview in the chart itself with minimal effort. We can iterate on this later and introduce another tab. |
About the changes
Network data usage may show connections instead of raw request count behind a flag.
This PR adjusts chart data to visualize connections count (1 connection = 7200 requests per day) in a day or in a month
Important files
Discussion points