fix: open/close animation on personal dashboard is choppy #9253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
thomasheartman
commented
Feb 7, 2025
Comment on lines
+41
to
+45
| props?.flags?.length && | ||
| (!state.activeFlag || | ||
| !props.flags.some( | ||
| (flag) => flag.name === state.activeFlag?.name, | ||
| )) |
There was a problem hiding this comment.
I took these out of variables because the linter didn't recognize props.flags as definitely being there if the variable was true. So to avoid using !, I put it in there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts each panel into its own component for the personal dashboard. This lets us use separate states for each panel, which in turn lets each panel change its open / close state without causing the other panels to re-render.
When you have a lot of flags and/or projects, the list to render becomes very long, which causes performance problems, especially when you need to rerender both flags and projects and the timeline whenever one of them changes.
The problems were especially noticeable in Firefox for me. Even with this, the event timeline is a little choppy. I suspect that's because of it might take a long time to paint? But we can look into that later.
Also updates the dashboard state hook to let you only pass in the flags/projects you want. We could extract this into three different hooks that all use the same localhost key, but I'm not sure whether that's better or worse 🤷🏼